Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Compound reliability formula uses wrong rate base
- Changed the formula to derive the per-call success rate via nth-root (success_rate^(1/avg_calls)) and return that as the compound reliability rate, instead of double-compounding the already-aggregate session success rate.
Or push these changes by commenting:
@cursor push 134ec109df
Preview (134ec109df)
diff --git a/src/primer/server/services/maturity_service.py b/src/primer/server/services/maturity_service.py
--- a/src/primer/server/services/maturity_service.py
+++ b/src/primer/server/services/maturity_service.py
@@ -866,7 +866,8 @@
avg_calls = bucket["total_call_count"] / len(bucket["sessions"])
if avg_calls <= 0:
return None
- return round(success_rate**avg_calls, 3)
+ per_call_rate = success_rate ** (1.0 / avg_calls)
+ return round(per_call_rate, 3)
customization_breakdown = [
CustomizationUsage(
diff --git a/tests/test_maturity.py b/tests/test_maturity.py
--- a/tests/test_maturity.py
+++ b/tests/test_maturity.py
@@ -551,13 +551,13 @@
assert read_tool["failure_session_rate"] == 0.5
assert read_tool["recovery_rate"] == 0.5
assert read_tool["success_rate"] == 0.5
- assert read_tool["compound_reliability_rate"] == 0.0
+ assert read_tool["compound_reliability_rate"] == 0.955
assert read_tool["abandonment_rate"] == 0.5
bash_tool = reliability_rows[("built_in_tool", "Bash")]
assert bash_tool["success_rate"] == 0.5
assert bash_tool["avg_calls_per_session"] == 2.0
- assert bash_tool["compound_reliability_rate"] == 0.25
+ assert bash_tool["compound_reliability_rate"] == 0.707
def test_maturity_builds_delegation_patterns(You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 1f22d68. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
PYTHONPATH=/Users/ccf/git/primer/src:/Users/ccf/git/primer pytest --import-mode=importlib tests/test_maturity.py -qruff check src/primer/common/schemas.py src/primer/server/services/maturity_service.py tests/test_maturity.pyruff format --check src/primer/common/schemas.py src/primer/server/services/maturity_service.py tests/test_maturity.pycd frontend && ./node_modules/.bin/eslint src/components/maturity/toolchain-reliability-table.tsx src/components/maturity/__tests__/toolchain-reliability-table.test.tsx src/types/api.tscd frontend && ./node_modules/.bin/vitest run --run src/components/maturity/__tests__/toolchain-reliability-table.test.tsxcd frontend && ./node_modules/.bin/tsc --noEmit